Skip to content

feat: Allen atlas improvements and RAS alignment#101

Open
FIrgolitsch wants to merge 1 commit into
pr-g-diagnostics-analysisfrom
pr-h-allen-atlas-ras
Open

feat: Allen atlas improvements and RAS alignment#101
FIrgolitsch wants to merge 1 commit into
pr-g-diagnostics-analysisfrom
pr-h-allen-atlas-ras

Conversation

@FIrgolitsch

@FIrgolitsch FIrgolitsch commented Apr 1, 2026

Copy link
Copy Markdown
Contributor

Stacked PR 4/22 — review order: #115#97#98#99#100#101#108#106#107#87#116#110#111#40#112#113#117#118#120#121#122#123#124#125

Base: pr-g-diagnostics-analysis. Retargets to main as upstream PRs merge.


PR #101 — Allen Atlas & RAS Alignment

Two commits: initial Allen/RAS work, then a fix for the RAS orientation logic plus a full test suite.

Changes

  • scripts/linum_align_to_ras.py (new, then refined) — align a reconstructed OME-Zarr volume to RAS orientation. Second commit fixes the orientation-code mapping (some axis flips were inverted) and tightens the auto-crop bounding box so background padding is removed consistently.
  • linumpy/io/allen.py — improved Allen atlas download / caching; adds numpy_to_sitk_image() and sitk_image_to_numpy() helpers used by the align-to-RAS pipeline and by feat: diagnostic and analysis scripts #100's diagnostics.
  • scripts/linum_download_allen.py — cache location made consistent with linumpy/io/allen.py; retries on transient HTTP errors.

Tests

  • linumpy/tests/test_io_allen.py — full unit coverage for linumpy/io/allen.py including the new SimpleITK helpers
  • scripts/tests/test_align_to_ras.py — regression tests covering the orientation-code mapping and the auto-crop bbox fixes

Notes

@FIrgolitsch FIrgolitsch force-pushed the pr-h-allen-atlas-ras branch 3 times, most recently from 6152f39 to 3350e25 Compare April 17, 2026 22:15
@FIrgolitsch FIrgolitsch changed the base branch from main to pr-c-utility-preprocessing April 17, 2026 22:22
@FIrgolitsch FIrgolitsch force-pushed the pr-h-allen-atlas-ras branch from 3350e25 to be216a4 Compare April 23, 2026 19:43
@FIrgolitsch FIrgolitsch changed the base branch from pr-c-utility-preprocessing to pr-a-build-tooling April 23, 2026 19:57
@FIrgolitsch FIrgolitsch force-pushed the pr-h-allen-atlas-ras branch from be216a4 to b5e36be Compare April 23, 2026 21:09
@FIrgolitsch FIrgolitsch force-pushed the pr-a-build-tooling branch 2 times, most recently from 82b44be to ce8e35d Compare April 23, 2026 21:23
@FIrgolitsch FIrgolitsch force-pushed the pr-h-allen-atlas-ras branch from b5e36be to 646b563 Compare April 23, 2026 21:23
@FIrgolitsch FIrgolitsch force-pushed the pr-h-allen-atlas-ras branch from 646b563 to a3a7b86 Compare April 23, 2026 21:28
@FIrgolitsch FIrgolitsch changed the base branch from pr-a-build-tooling to pr-g-diagnostics-analysis April 27, 2026 23:36
@FIrgolitsch FIrgolitsch force-pushed the pr-g-diagnostics-analysis branch from 53772da to c858c1a Compare April 29, 2026 19:39
@FIrgolitsch FIrgolitsch force-pushed the pr-h-allen-atlas-ras branch from a3a7b86 to c19c4d7 Compare April 29, 2026 19:39
@FIrgolitsch FIrgolitsch force-pushed the pr-g-diagnostics-analysis branch from c858c1a to ad4fc82 Compare April 30, 2026 03:21
@FIrgolitsch FIrgolitsch force-pushed the pr-h-allen-atlas-ras branch from c19c4d7 to 5e7482c Compare April 30, 2026 03:21
@FIrgolitsch FIrgolitsch force-pushed the pr-g-diagnostics-analysis branch from ad4fc82 to 899c734 Compare April 30, 2026 03:26
@FIrgolitsch FIrgolitsch force-pushed the pr-h-allen-atlas-ras branch from 5e7482c to d47cbd7 Compare April 30, 2026 03:26
@FIrgolitsch FIrgolitsch force-pushed the pr-g-diagnostics-analysis branch from 899c734 to 36613aa Compare April 30, 2026 03:51
@FIrgolitsch FIrgolitsch force-pushed the pr-h-allen-atlas-ras branch from d47cbd7 to 31f7811 Compare April 30, 2026 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant